On Sun, Nov 22, 2009 at 01:10:11PM +0000, rubisher wrote:
> But as far as the 1st parameter of grub_vsprintf is a pointer,
> wouldn't it be better to write:
> --- kern/misc.c.orig 2009-11-22 13:07:22.000000000 +0000
> +++ kern/misc.c 2009-11-22 13:07:51.000000000 +0000
> @@ -160,7 +160,7 @@
> {
> int ret;
>
> - ret = grub_vsprintf (0, fmt, args);
> + ret = grub_vsprintf (NULL, fmt, args);
> return ret;
> }
Yes. But we have many of those, so we don't go huntin' them. If you'd
like to help us, a patch that does this change in bulk would be welcome.
Thanks
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
