Hello all,
I am just reading kernel/misc.c file and read grub_vsprintf() definition as:
int
grub_vsprintf (char *str, const char *fmt, va_list args)
which is used by:
int
grub_vprintf (const char *fmt, va_list args)
{
int ret;
ret = grub_vsprintf (0, fmt, args);
return ret;
}
But as far as the 1st parameter of grub_vsprintf is a pointer,
wouldn't it be better to write:
--- kern/misc.c.orig 2009-11-22 13:07:22.000000000 +0000
+++ kern/misc.c 2009-11-22 13:07:51.000000000 +0000
@@ -160,7 +160,7 @@
{
int ret;
- ret = grub_vsprintf (0, fmt, args);
+ ret = grub_vsprintf (NULL, fmt, args);
return ret;
}
Tia,
J.
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
