On Wed, Oct 14, 2009 at 01:43:05PM +0100, Colin Watson wrote: > On Wed, Oct 14, 2009 at 02:28:48PM +0200, Robert Millan wrote: > > Note: Some string lengths were hardcoded, and they're being replaced with > > sizeof() statements. I triple-checked them for off-by-one mistakes, but it > > doesn't hurt if someone else reviews it. Please avoid hardcoding constant > > string lengths! It makes it more error-prone to change those strings later. > > I reviewed the string code and it looks fine.
Thanks Colin. I committed this. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
