On Wed, Oct 14, 2009 at 02:28:48PM +0200, Robert Millan wrote: > Note: Some string lengths were hardcoded, and they're being replaced with > sizeof() statements. I triple-checked them for off-by-one mistakes, but it > doesn't hurt if someone else reviews it. Please avoid hardcoding constant > string lengths! It makes it more error-prone to change those strings later.
I reviewed the string code and it looks fine. -- Colin Watson [cjwat...@ubuntu.com] _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
