On Mon, Jun 22, 2009 at 05:45:54PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-22 at 23:22 +0200, Robert Millan wrote: > > On Mon, Jun 22, 2009 at 04:51:43PM -0400, Pavel Roskin wrote: > > > > > > You may want to use 4 byte alignment too. It's a good thing to align > > > 32-bit addresses in the ELF headers. > > > > Ok, but we aren't doing it on i386-pc, and this never caused trouble. The > > ELF headers in our modules are only loaded by GRUB itself, and if our > > loader can cope with unaligned addresses, why bother trying to align > > them? > > Maybe to speed up things. But I don't really care.
Well, if there's interest in doing this, I would suggest finding a platform-independant way. For example the modinfo structure could remain unaligned, with padding in-between its ELF modules or so. If there's a speed improvement I'm fine with it. But I can sleep at night without alignment :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
