On Mon, Jun 22, 2009 at 12:16:35PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-22 at 12:10 +0200, Robert Millan wrote: > > > My aim was to move this to C code so it can be shared between i386-qemu > > and i386-coreboot. However, this code will be the same on other i386 > > ports, but we don't yet have a generic .S file for i386 code. > > > > How about kern/i386/misc.S ? > > Fine with me. We shouldn't switch to inferior C code just because we > don't have a shared .S file.
Agreed. I just replaced the 3 instances we had of grub_stop() with a single one in kern/i386/misc.S. > Anyway, I think grub_halt() should be renamed to grub_poweroff() to be > more explicit about its goal. Fine with me. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
