On Sat, Aug 30, 2008 at 11:41:18AM -0400, Pavel Roskin wrote:
> Quoting Robert Millan <[EMAIL PROTECTED]>:
>
> >So this patch means to solve both issues; makes single-disk drivers use a
> >constant directly (since a pointer to string is meaningless and confusing),
> >and disk/scsi.c use LUNs which (I believe) will work as unique identifiers.
>
> Multi-character constants cause warnings.
Can we silence them?
> That's why I changed them
> to strings. Pointers to different strings are different, and that's
> all we need.
For single-disk drivers, yes. But that has two problems:
- People tend to think the string itself has a meaning. We could avoid
this by using "dummy" or so.
- People tend to think it's fine to do the same for multi-disk drivers.
We could avoid this by adding a short comment in each of them.
> If you prefer numeric IDs, perhaps we'll need a header
> file with all IDs we support. Alternatively, we need a macro that
> would convert characters to an ID.
I agree that this is harder to maintain. I'd be happy with any solution that
works correctly and prevents confusion.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
