On Mon, 2008-01-21 at 22:09 +0100, Robert Millan wrote:
> On Mon, Jan 21, 2008 at 12:47:06PM -0500, Pavel Roskin wrote:
> >
> > I've tested the patch, and it seems to be OK, although I was surprised
> > to see an empty menu on startup. Perhaps a command line would be more
> > appropriate in absence of grub.cfg?
>
> I wanted to send a new mail about this, and then forgot.
>
> This is because of a bug in cpio.mod. The menu code thinks grub.cfg is
> present due to grub_cpio_find_file() returning here:
>
> if (!hd.name[0])
> {
> *ofs = 0;
> return GRUB_ERR_NONE;
> }
>
> but I'm too clueless about tar format to figure this out.
I guess the meaning of GRUB_ERR_NONE is confusing (no file vs. no
error), and the return value of grub_cpio_find_file() is not well
defined.
Perhaps it should be GRUB_ERR_FILE_NOT_FOUND instead.
--
Regards,
Pavel Roskin
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
