On Mon, 2008-01-21 at 22:06 +0100, Robert Millan wrote: > On Mon, Jan 21, 2008 at 12:47:06PM -0500, Pavel Roskin wrote: > > On Mon, 2008-01-21 at 17:52 +0100, Robert Millan wrote: > > > These two were predestined to get together.. attached patch for their > > > wedding. > > > > > > Comments? > > > > I really like the ability to add more things than just modules > > (especially grub.cfg and fonts). Is that the main motivation for your > > patch? Or you have some other things in mind? > > Yes, that's it. Specially for situations in which there's no other way > (like netboot images, or in the future coreboot when it works on ELF).
I wish I could use it on PowerPC to work around the "claim failed" problem, but I'll still need to link "memdisk" and "cpio" with grub-mkimage. I have a patch for PowerPC, but I think I'll hold it until your patch is committed. I could change my patch to be more in-sync with i386, in particular use /boot/grub as the blessed directory. > > I don't quite understand why "biosdisk" needs to be mandatory. I guess > > it's not initialized by default, so that it doesn't conflict with the > > ata module. But ata can load on top of biosdisk (but not the other way > > around). > > I just added it because we don't seem to have a way to define which modules > should be autoloaded (other than grub.cfg itself). And I'm afraid not loading > it by default will confuse users. I don't know how to improve this, but ideas > are welcome, of course. Actually, if biosdisk is a part of the core image, other modules are preloaded. I don't quite understand the mechanism. I think it should be OK for now. Then we can refine the loading and the initialization. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
