Bean <[EMAIL PROTECTED]> writes: > On 8/3/07, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Bean <[EMAIL PROTECTED]> writes: >> >> > On 8/3/07, Marco Gerards <[EMAIL PROTECTED]> wrote: >> >> Bean <[EMAIL PROTECTED]> writes: >> >> >> >> >> If you make these two changes and send in the patch, I'll commit the >> >> >> patch. >> >> >> >> >> > >> >> > Ok, this is the new patch. >> >> >> >> Committed. >> >> >> > >> > Thanks, but i don't see fs/ntfs.c in the cvs, do you forget to add it ? >> >> Yes, I forgot it, but now it is really committed. >> >> > As ntfs driver is done, i start to work on the scripting support. Does >> > the parser in the previous test program ok ? >> >> To be honest, I just didn't find the time yet :(. >> >> Actually, I hoped you could first update the other patch regarding >> scripting. There was one part of the patch I didn't like. If you can >> take that out, at least the other parts can be committed without much >> of a problem. > > Which part ? Do you mean the new lexer code in grub_script_yylex2 ?
Yes. >> About that other parser file? Personally I don't like it if you would >> start from working from scratch on the parser. The way ASTs and stuff >> are build now is just fine, although not perfect. However, if you >> improve the current parsing rules that would be great. I do not have >> much time today, so if I will not have the time today, I'll try to >> look after this weekend. >> > > Yes, we can just use the parsing rules, AST and related stuff will > remain the same. > > But I think the lexer code need to be changed, the current lexer will > break the following token: > > "aa$BB" > > into aa and $BB, but in fact, it should act as one. I will look into this problem soon. At the time I just ignored it to speed up the implementation, sorry for that. Do you object if the other part is applied? I would appreciate it if you had the time to make a new patch... -- Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
