On 8/3/07, Marco Gerards <[EMAIL PROTECTED]> wrote: > Bean <[EMAIL PROTECTED]> writes: > > Hi, > > > I improve the driver a little bit. Now it uses grub_fshelp_read_file > > to read uncompressed files. I also disable the hook when reading > > compressed files, because disk layout doesn't make much sense for > > compressed data. > > You didn't fix some issues I mentioned in my first review: > > - You use u16at, etc. Can you please replace those by the matching > functions like grub_le_to_cpu16, etc?
I'm not quite sure what you mean. The u16at is a macro that calls grub_le_to_cpu16: #define u16at(buf,ofs) grub_le_to_cpu16(valueat(buf,ofs,grub_uint16_t)) > - You have unclear errors like "B2". Can you improve those so I know > what went wrong if I get such error? I'm sorry, I forget to change this one. > - Clean up the list of include files I think these two can be omit: #include <grub/err.h> #include <grub/types.h> -- Bean _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
