Hollis Blanchard <[EMAIL PROTECTED]> writes: > On Wed, 2006-05-31 at 00:08 +0300, Vesa Jääskeläinen wrote: > > Attached patch fixes problems for compiling correct code on i386-pc... > > other platforms needs to be modified similarly too... > > I'm confused by this; could you explain? If _TARGET_CFLAGS is used for > everything to be run on the target, perhaps we should just rename > _CFLAGS to _TARGET_CFLAGS. > > Also, in the future, could you please supply best-guess code for other > architectures? It's ok if you don't know, but in this case it seems it > would be easy enough to duplicate your i386-pc.mk changes for the > other .mk files. I am also confused. Is this keeping to the changes presented by Okuji? I don't think it is best to move from CFLAGS to something different, this would make it odd when porting to other OS, it also seems off convention.
Okuji's post: http://lists.gnu.org/archive/html/grub-devel/2006-05/msg00106.html Cheers Harley _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
