On Wed, 2006-05-31 at 00:08 +0300, Vesa Jääskeläinen wrote: > Attached patch fixes problems for compiling correct code on i386-pc... > other platforms needs to be modified similarly too...
I'm confused by this; could you explain? If _TARGET_CFLAGS is used for everything to be run on the target, perhaps we should just rename _CFLAGS to _TARGET_CFLAGS. Also, in the future, could you please supply best-guess code for other architectures? It's ok if you don't know, but in this case it seems it would be easy enough to duplicate your i386-pc.mk changes for the other .mk files. > Index: conf/common.rmk > =================================================================== > RCS file: /sources/grub/grub2/conf/common.rmk,v > retrieving revision 1.7 > diff -u -r1.7 common.rmk > --- conf/common.rmk 27 May 2006 21:09:25 -0000 1.7 > +++ conf/common.rmk 30 May 2006 21:00:02 -0000 > @@ -27,61 +27,73 @@ > # For fshelp.mod. > fshelp_mod_SOURCES = fs/fshelp.c > fshelp_mod_CFLAGS = $(COMMON_CFLAGS) > +fshelp_mod_TARGET_CFLAGS = $(COMMON_TARGET_CFLAGS) > fshelp_mod_LDFLAGS = $(COMMON_LDFLAGS) ... > --- conf/i386-pc.rmk 28 May 2006 23:01:43 -0000 1.65 > +++ conf/i386-pc.rmk 30 May 2006 21:00:02 -0000 > @@ -2,6 +2,7 @@ > > COMMON_ASFLAGS = -nostdinc -fno-builtin > COMMON_CFLAGS = -fno-builtin -mrtd -mregparm=3 -m32 > +COMMON_TARGET_CFLAGS = -fno-builtin -mrtd -mregparm=3 -m32 > COMMON_LDFLAGS = -melf_i386 -nostdlib _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
