Hi Brendan,
> > On Solaris 11.4, 203 tests fail.
> >
> > All of them because they use 'grep' and the Solaris /usr/bin/grep is
> > old. But there is also /usr/bin/ggrep, which is GNU grep version 3.1.
> > In fact, config.status contains two AC_SUBSTed variables:
> > GREP -> "/usr/bin/ggrep"
> > EGREP -> "/usr/bin/ggrep -E"
> > But the test suite appears to not use these variables.
>
> Right. I have not been in the habit of generating test scripts at
> configuration time from '*.in' files that we ship.
That would certainly be overkill.
All that is needed is to
1) Change the top-level Makefile.am
AM_TESTS_ENVIRONMENT = \
abs_top_srcdir=$(abs_top_srcdir) \
abs_top_builddir=$(abs_top_builddir) \
export abs_top_srcdir abs_top_builddir;
→
AM_TESTS_ENVIRONMENT = \
abs_top_srcdir=$(abs_top_srcdir) \
abs_top_builddir=$(abs_top_builddir) \
GREP=$(GREP) \
export abs_top_srcdir abs_top_builddir GREP;
The configure-time finding for GREP will then be passed through the
environment.
2) Change the 203 tests that use 'grep' to use ${GREP} instead.
Or ${GREP:-grep} if you want to preserve the ability to run individual
tests without going through 'make check'.
Bruno
