Hi Ingo,

On Mon, Sep 22 2014 at 10:38:40 PM, Ingo Schwarze <schwa...@usta.de> wrote:
> You might also wish to add a sentence like the following to
> INSTALL.REPO, right after "1. Initial build", before "First invoke
> the bootstrap script:"
>
>   On operating systems supporting concurrent installation of multiple
>   versions of the autotools, set the following environment variables:
>
>   export AUTOMAKE_VERSION=1.12
>   export AUTOCONF_VERSION=2.65

Good suggestion, I've added a short explanation in INSTALL.REPO
(commited).

> Regarding the configure script, here is a list of things it gets
> wrong:
>
>  - it prefers /usr/local/bin/ggrep over /usr/bin/grep in both
>    of the following tests:
>    checking for grep that handles long lines and -e...
>    checking for egrep...
>
>  - it prefers /usr/local/bin/gmkdir over /bin/mkdir in the test
>    checking for a thread-safe mkdir -p
>
>  - checking for style of include used by make... GNU
>    that makes no sense at all, it's a POSIX-compatible BSD make
>
>  - it prefers /usr/local/bin/gsed over /usr/bin/sed
>
>  - it prefers /usr/local/bin/bison over /usr/bin/yacc
>
> Prefering the GNU versions over the native POSIX versions is bad
> because it causes needless build dependencies.

OK, but all this will happen on master too. If needed, we can work on
that after the automake migration.

> And then finally, "make" dies here:
>
>   FILEMODE=`echo contrib/groffer/roff2dvi.man | \
>     sed 's|contrib/groffer/roff2\([a-z]\+\)\.man|\1|g'` && \
>     sed -e 's/[@]ROFF2MODE[@]/'"$FILEMODE"'/g' \
>     ../contrib/groffer/roff2.man > contrib/groffer/roff2dvi.man;
>   sed: 1: "s/[@]ROFF2MODE[@]/contr ...: bad flag in substitute command: 'r'
>   *** Error 1 in . (Makefile:8589 'contrib/groffer/roff2dvi.man')
>   *** Error 1 in /co/groff/build (Makefile:3713 'all')
>
> The problem here is that basic regular expressions don't have a "+"
> bound.  So the subexpression needs to be written as
>
>   \([a-z][a-z]*\)

Commited too.

> With that issue fixed, the build finishes.  I can't say yet
> whether it's correct and works.
>
> I didn't come round to testing "make dist" yet, but wanted to report
> what i found so far, anyway.

Thanks for testing !

Regards,

--
Bertrand Garrigues

Reply via email to