gotmax23 commented on the pull-request: `Fix goname generation to match 
versioning guildelines` that you are following:
``
> > Also, this is a breaking change that I would not feel comfortable 
> > backporting to stable branches, whether Fedora or (EP)EL.
> 
> I don't understand why for stable branches, we know the changes we have made 
> and the impact it will have. There is not reason it will impact the thousands 
> of non versioned packages, and will affect the list of packages we already 
> know about.
>
> For EPEL, there is basically no impact as we don't have libraries packages 
> there. We don' t even need to backport there.

There are at least four packages in EPEL 9 that would be impacted by this 
change.

```
$ fedrq pkgs -b epel9 -s -Fname \* | rg 'golang-.*-\d+$'
golang-gopkg-check-1
golang-gopkg-russross-blackfriday-2
golang-gopkg-yaml-2
golang-gopkg-yaml-3
```

I do not feel comfortable backporting this to older Fedoras and definitely not 
in EPEL. It's a breaking change that will cause packages to stop building in 
distgit.

Also, the lists we have been working off of aren't even all inclusive. 
compat-golang-*-devel packages also use this logic:

```
$ fedrq pkgs -S -b rawhide -Fname compat-\*golang\*-devel | rg 
'compat-golang-.*-\d+-devel$' | wc -l
82
$ fedrq pkgs -S -b epel9 -Fname compat-\*golang\*-devel | rg 
'compat-golang-.*-\d+-devel$' | wc -l
4
```

We'd have to identify all of these impacted packages and then make a bunch of 
mass changes accross distgit branches, while being quite careful not to break 
anything. We have enough brokenness in the Go ecosystem, and I don't think we 
need to add more potential pitfalls. I'd rather make a oneline change in go2rpm 
to add this flag everywhere than have to rebuild and mass change 100-200 
packages

> > See my (only lightly tested) suggestion in 
> > https://pagure.io/fork/gotmax23/go-rpm-macros/commits/alt_fix_goname.
> 
> I don't get the change you made to gorpmname.

I made it so it always uses a `_` to separate a version from the import path 
when `go_use_new_versioning` is set and otherwise use a `-`. Did I not 
understand what the FPC asked for?
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/56
_______________________________________________
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to