eclipseo commented on the pull-request: `Fix goname generation to match 
versioning guildelines` that you are following:
``
> This is likely to cause confusing behavior across branches and other issues

Unlikely, we know the list of packages that will be affected and we just need 
update theses ones in stable branches in a side tag with the go-rpm-macros 
package.

> we cannot make changes willy-nilly without affecting many packages inside and 
> outside the Fedora repositories

For inside, we know the impact. For outside Fedora, 1) this is not our issue 2) 
the impact would only be on versioned golang packages, which itself is a very 
limited scope, 3) The impact would only be the name of the package, it wouldn't 
cause problems like if it was in dist-git and fail the build.

> Also, this is a breaking change that I would not feel comfortable backporting 
> to stable branches, whether Fedora or (EP)EL.

I don't understand why for stable branches, we know the changes we have made 
and the impact it will have. There is not reason it will impact the thousands 
of non versioned packages, and will affect the list of packages we already know 
about.

For EPEL, there is basically no impact as we don't have libraries packages 
there. We don' t even need to backport there.

> See my (only lightly tested) suggestion in 
> https://pagure.io/fork/gotmax23/go-rpm-macros/commits/alt_fix_goname. 

I don't get the change you made to gorpmname.
``

To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/56
_______________________________________________
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to