On Mon, Jul 8, 2019 at 10:54 PM Tamás Gulácsi <tgulacs...@gmail.com> wrote:
>
> // Wait on the channel, or for timeout
> select {
> case fd := <-channel:
> return fd, nil
> case <-time.After(queue.timeout):
> // Check again
> select {
> case fd := <-channel:
> return fd, nil
> default:
> return nil, ErrTimeoutElapsed
> }
> }
I believe this is wrong. If timeout happens first and the fd is sent
after the second select runs, the sender is stuck.
Two selects and another cancel channel might work:
sending side:
select {
case <- cancel:
close(fd)
case channel<- fd:
}
receiving side:
select {
case fd:=<-channel:
return fd,nil
case <-time.After(...) :
close(cancel)
return nil, ErrTimeout
}
}
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-nuts" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-nuts+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/golang-nuts/9ca56ba4-dcc2-4e1a-a0e8-5e2463042455%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to golang-nuts+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/golang-nuts/CAMV2RqoVXmA8jMMtaeh8D2g_Em0Sk512VKwaGuYaTxwVP4iioA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
