Thanks a million rog!
I completely understand what you say. Regarding to the performance, I
didn't expect as bad performance as I found yesterday when running my
benchmark test and I will be focused on being able to improve it as much as
I can.
I found a way to improve performance in primitive arrays but keeping the
generic interface. I just started with the reduce operation
The below test, yesterday took 7.08 ns/op vs 4000ns/op aprox. Today I am
in 400ns/op vs 7....
var numbers10 = utils.ArrayOfInt(0, 1, 10)
func BenchmarkSum10(b *testing.B) {
for i := 0; i < b.N; i++ {
result := 0
for _, v := range numbers10 {
result += v
}
output = result
}
}
func BenchmarkSum10Koazee(b *testing.B) {
for i := 0; i < b.N; i++ {
output2 := koazee.
StreamOf(numbers10).
Reduce(func(acc, val int) int { return acc + val }).
Val()
}
}
To improve the performance I am focused on making the operations smarter.
As soon as I got it working I will share with you,
Thank you again for all the suggestion and recommendation guys! Very
appreciated.
El martes, 13 de noviembre de 2018, 21:15:17 (UTC+1), rog escribió:
>
> It's obvious that you've put a lot of effort into this! Here's some
> feedback.
>
> I have to say this first: this *is* a very non-Go-idiomatic API. It's
> fundamentally based around reflection, and reflection in Go is generally
> considered to be best avoided apart from some core libraries. Calling a
> function with reflect is orders of magnitude slower than calling it
> directly, and the lack of compiler type checking can make for code that's
> hard to understand when it goes wrong. So I wouldn't use this in production
> code.
>
> That said, it's a fun API and a great way to experiment with some of the
> things that can be done in Go if we sacrifice compile-type type checking.
>
> Taking it at face value, here are a few random thoughts:
>
> - improve the doc comments. Go automatically generates documentation for
> you (for example https://godoc.org/github.com/wesovilabs/koazee/stream)
> and that's the usual place for people to read package documentation.
> Everything that's exported should have a relevant doc comment. There
> shouldn't be any need to generate custom API documentation.
>
> - avoid making public methods return private types. When a public method
> returns a private type, the documentation fails because it does not display
> methods on private types.
>
> - it's almost always better to use the builtin sort package (
> https://golang.org/pkg/sort) rather than rolling your own.
>
> - it's probably best not to use an arbitrary definition of equality
> (stream.equalsValues), but to either use plain "==" or accept an equality
> function.
>
> - it would be nice for it to work on arbitrary streams. This actually
> isn't too hard. Here's a way of doing it that works on an arbitrary
> Iterator interface, so it can iterate over channels, bufio.Scanner, etc.
> https://play.golang.org/p/PXHuD1pR5uC
>
> Finally, if/when generics eventually make it into Go, this kind of API
> will no longer have a huge overhead. I think I'd probably wait until
> then... :)
>
> cheers,
> rog.
>
> On Sun, 11 Nov 2018 at 19:27, Iván Corrales Solera <
> ivan.corra...@gmail.com <javascript:>> wrote:
>
>> Hey guys, last weeks I've been working on Koazee and I just released a
>> very first version Titi, v0.0.1 . Koazee is a golang library inspired in
>> Lazy evaluation and functional programming that provides us a rich set of
>> operations that can be done over arrays. If you like the clean code and the
>> functional programming I am sure you enjoy it!
>>
>> Documentation is hosted http://wesovilabs.com/koazee/
>>
>> And the full code can be found on Github,
>> https://github.com/wesovilabs/koazee
>> Any feedback or recommendation will be appreciated! Cheers
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-nuts" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-nuts...@googlegroups.com <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
--
"Este mensaje está
dirigido de manera exclusiva a su destinatario y puede
contener información
privada y confidencial. No lo reenvíe, copie o
distribuya a terceros que no
deban conocer su contenido. En caso de haberlo
recibido por error, rogamos
lo notifique al remitente y proceda a su
borrado, así como al de cualquier
documento que pudiera adjuntarse.
Por
favor tenga en cuenta que
los correos enviados vía Internet no permiten
garantizar la confidencialidad de
los mensajes ni su transmisión de forma
íntegra.
Las opiniones expresadas en el
presente correo pertenecen
únicamente al remitente y no representan
necesariamente la opinión del
Grupo BBVA."
"This
message is intended exclusively for the adressee and
may contain privileged and
confidential information. Please, do not
disseminate, copy or distribute it to
third parties who should not receive
it. In case you have received it by
mistake, please inform the sender and
delete the message and attachments from
your system.
Please
keep in
mind that e-mails sent by Internet do not allow to guarantee neither
the
confidentiality or the integrity of the messages sent."
--
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to golang-nuts+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
