> I haven't thought too much about it but there is possibly an alternative > logic by having the wrappers add a Wrap() http.ResponseWriter that would > return the wrappee. > > So first, one would test for that Wrapper interface, then return the wrappee > if the test turns out to be positive. Then one could assert for various > interfaces on this wrappee. > > Something to think about.
Maybe I’m misunderstanding your idea, but wouldn’t this require having to go over every handler used by the application in order to see where this is needed? If yes, then I don’t like it, because that’s exactly what I was trying to avoid. The whole idea was to make the wrapping/instrumentation transparent to all handlers. Cheers Felix > On 11 Nov 2016, at 11:35, atd...@gmail.com <atd...@gmail.com> wrote: > > I haven't thought too much about it but there is possibly an alternative > logic by having the wrappers add a Wrap() http.ResponseWriter that would > return the wrappee. > > So first, one would test for that Wrapper interface, then return the wrappee > if the test turns out to be positive. Then one could assert for various > interfaces on this wrappee. > > Something to think about. > > On Thursday, November 10, 2016 at 12:09:32 PM UTC+1, Felix Geisendoerfer > wrote: > Hi all, > > while working on instrumenting my application, I ran into the fact that > capturing metrics such as status codes from my own http.Handlers is > surprisingly difficult to get right. > > Therefor I created a package that hopefully avoids most of the common > pitfalls. > > https://github.com/felixge/httpsnoop <https://github.com/felixge/httpsnoop> > > I would love for net/http experts to take a look at the "Why this package > exists" section of the README, as well as the horrible hack required to make > things work: > > https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163 > <https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163> > > Please let me know if you have suggestions for simpler approaches and/or spot > any bugs in my implementation. > > Thanks a lot! > Felix Geisendörfer > > -- > You received this message because you are subscribed to a topic in the Google > Groups "golang-nuts" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/golang-nuts/-I5IZgJosYE/unsubscribe > <https://groups.google.com/d/topic/golang-nuts/-I5IZgJosYE/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > golang-nuts+unsubscr...@googlegroups.com > <mailto:golang-nuts+unsubscr...@googlegroups.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
