> I think an interface like this should be provided in net/http package to > make it easy to capture the response.
Yeah, I was hoping the new http tracing stuff would allow for this kind of instrumentation, but unfortunately it’s targeted at different aspects of the request/response cycle. Cheers Felix > On 11 Nov 2016, at 00:55, Hirotaka Yamamoto (ymmt2005) <ymmt2...@gmail.com> > wrote: > > Hi, > > I had implemented and blogged the technique to properly wrap > http.ResponseWriter: > http://ymmt2005.hatenablog.com/entry/2016/09/01/How_to_hack_Go%27s_http_Server_correctly > > type StdResponseWriter interface { > http.ResponseWriter > io.ReaderFrom > http.Flusher > http.CloseNotifier > http.Hijacker > WriteString(data string) (int, error) > } > > I think an interface like this should be provided in net/http package to > make it easy to capture the response. > > 2016年11月10日木曜日 20時09分32秒 UTC+9 Felix Geisendoerfer: > Hi all, > > while working on instrumenting my application, I ran into the fact that > capturing metrics such as status codes from my own http.Handlers is > surprisingly difficult to get right. > > Therefor I created a package that hopefully avoids most of the common > pitfalls. > > https://github.com/felixge/httpsnoop <https://github.com/felixge/httpsnoop> > > I would love for net/http experts to take a look at the "Why this package > exists" section of the README, as well as the horrible hack required to make > things work: > > https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163 > <https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163> > > Please let me know if you have suggestions for simpler approaches and/or spot > any bugs in my implementation. > > Thanks a lot! > Felix Geisendörfer > > -- > You received this message because you are subscribed to a topic in the Google > Groups "golang-nuts" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/golang-nuts/-I5IZgJosYE/unsubscribe > <https://groups.google.com/d/topic/golang-nuts/-I5IZgJosYE/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > golang-nuts+unsubscr...@googlegroups.com > <mailto:golang-nuts+unsubscr...@googlegroups.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
