Thanks John, indeed it's all right there in that file. I somehow assumed github "search in the repository" would return it when searching on one of the old option names "Show Accounts until level" but it doesn't. Not sure what's happening with github search because I have definitively used it in the past to locate code. I'll be sticking to grep from now on.
This is for a PR I'll be submitting later for "Bug 765920 - Running balance on report is not accurate when report is sorted in different ways". One solution we discussed was to rename the feature to "Account Balance at Transaction" to make it clearer it's not always a running balance, only when the transactions are sorted as in the register. This is also in preparation for an enhancement that was discussed in an older PR on version about adding running totals to the transaction report -- but running totals based on the report transaction and sort order, not the account balance. See at https://github.com/Gnucash/gnucash/pull/1460 . So the renaming is also to avoid confusion between the 2 features. In any case I'll post an update on the bug report and it can be discussed further on a new PR later. Sincerely, Vincent Dawans On Mon, Apr 10, 2023 at 9:51 PM john <jra...@ceridwen.us> wrote: > The name map is now in libgnucash/engine/gnc-optiondb.cpp and named class > OptionAlias. It is not public and so > not available for custom reports to add their options to it. > > As usual for GnuCash backwards compatibility is only with the last major > release, though in the case of saved reports > nothing significant has changed since GnuCash 3.0. If you encounter a > saved report configuration contained in saved-reports-2.8 not being read > please file a bug. If it's from saved-reports-2.4 or earlier you'll have > to recreate them. > > Regards, > John Ralls > > > On Apr 10, 2023, at 8:42 PM, Vincent Dawans <dawa...@gmail.com> wrote: > > > > In version 4, /libgnucash/app-utils/options.scm was the file in which a > > list of old names and new names of report options that had been renamed > > could be paired to maintain backward compatibility with saved report > > configurations. This was via the option database code, inside > > the new-names-alist function. > > > > How does that work in version 5 with the report option code rewrite? I > find > > ./gnucash/bindings/guile/options.scm but I don't see where I am supposed > to > > put the option renaming code in this version if it's even in that file. > > > > I assume the correspondence list from version 4 should still be somewhere > > but a search on some of the old option renaming does not return anything. > > Do we not keep backward compatibility for saved report configurations > when > > going to the next major version? Regardless, if I want to propose > renaming > > an option in a PR, what code do I need to put where to keep backward > > compatibility? > > > > Sincerely, > > > > Vincent Dawans > > _______________________________________________ > > gnucash-devel mailing list > > gnucash-devel@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > > _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
