My change was merely to reuse an existing string in the lot viewer, for its exact same purpose.
Perhaps the original committer [1] needs to be informed? [1] https://github.com/Gnucash/gnucash/commit/0b37c913f053f86196f6cd6689fcaba2e08b387e On Mon, 12 Sept 2022 at 04:53, Frank H. Ellenberger < frank.h.ellenber...@gmail.com> wrote: > Christian, > > idid you check all other occurrences. If yes, I would like to add the > MsgContext "Adjective" to dialog-lot-viewer.c and run a msgmerge. > > Regards > Frank > > Am 11.09.22 um 22:05 schrieb Christian Stimming: > > Hi Christopher, > > > > in gnucash/gnome/dialog-lot-viewer.c you recently added the function > > lot_get_closing_date() which might return the translated string "Open" > if there is no such > > closing date because the lot is still in the status "opened". > > > > There's an issue with this translation string: It is super-ambiguous. In > most contexts, a > > translation string "Open" is used in the sense "to open [something]" but > the string is just > > "Open" ie the verb. Contrary to this, in this particular place the > string should mean > > "[something is in state] Open" but the string is also just "Open", ie > the adjective. This won't > > work for translators, because in almost all other languages, the verb > and the adjective will be > > two vastly different strings. > > > > The solution is to use the C_( ) macro instead of _( ) which is where > the additional context > > string is used. > > https://www.gnu.org/software/gettext/manual/html_node/Contexts.html[1] > > https://wiki.gnucash.org/wiki/Translation#Message_Context[2] > > > > This way, the string "Open" with no context should be used only when > this is the verb > > meaning ie "to open", but not for the status as it is in this file here. > > > > Thanks a lot! > > > > Regards, > > Christian > > > > -------- > > [1] https://www.gnu.org/software/gettext/manual/html_node/Contexts.html > > [2] https://wiki.gnucash.org/wiki/Translation#Message_Context > > _______________________________________________ > > gnucash-devel mailing list > > gnucash-devel@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
