On Sat, 2006-04-29 at 18:22 -0400, Mike Alexander wrote: > Thanks for committing this. Sorry about not putting it in bugzilla. > I'll transfer this there if you think it would be useful.
I probably would have found it and committed it earlier, but this is fine for me. > I see that you changed the code in gnc_lot_get_balance_before. Not intentionally. > The gains splits are put in a separate transaction by the capital gain > scrubbing code, and the transaction sorting code may sort gains splits > after other splits on the same day (and did in my case). This meant > that the second disposal on the same day didn't work right since the > capital gains from the first disposal weren't considered in calculating > the basis for the second disposal. I should have added some comments > documenting why I did this. That would be helpful. > I've attached a patch the shows what I'm talking about. It also > patches cap-gains.[ch] to define the xaccSplitGetGainsSourceSplit > method used to find the source split associated with a capital gains > split. There are some other changes in the cap-gains.[ch] patch which > might be worth considering. They are mostly to more consistently use > lot_amount and lot_value rather than opening_amount and opening_value. I've applied this patch too. I don't think anyone else is working on this code, so I'm willing to take whatever changes you have. David _______________________________________________ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
