Dave Peticolas <[EMAIL PROTECTED]> writes:

> > gnucash: [D] "Running functions on hook "main-window-opened-hook
> > ERROR: Bad define placement
> 
> This may be related to the problem that Rob B. found with running
> out of the build directory and auto-loading the reports files.
> I think Rob is fixing this, but in the meantime you might try
> an /opt style install so you can easily remove it and see if
> that works.

I've fixed the reports problem, this problem, and some other stuff
(see patch below, and the ChangeLog entries for the precise list).

The reports problem and the define problem were unrelated.  This
"define" problem was due to some defines being in "illegal" locations.
According to r5rs, a nested define can only be at the beginning of a
<body>, and a "begin" doesn't introduce a <body>, only a series of
expressions.  So

  (begin
    (define foo 4)
    #t)

is illegal, but

  (let ()
    (define foo 4)
    #t)

is not...

In this patch, I've also augmented the make-gnucash-patch script so
that it allows you to override its defaults with environment
variables.  This means that you can make sure you're always running
the latest version without having to edit it by using a wrapper script
like this:

  #!/bin/bash

  export GNC_MAKEPATCH_HOME_DIR="/home/rlb/gnucash"
  export GNC_MAKEPATCH_OLD_DIR="upstream"
  export GNC_MAKEPATCH_NEW_DIR="working"

  ${GNC_MAKEPATCH_HOME_DIR}/${GNC_MAKEPATCH_NEW_DIR}/make-gnucash-patch

Also, I hope no one minds, but I've changed the reports code over to
using the normal depend mechanism, but scm/report/report-list.scm is
where you can list the reports to be loaded.  The reports themselves
also use this mechanism so they can depend on each other, and the
interdependences are now explicit.

If anyone cares, the reasons I wanted to switch from autoloading are
that autoloading (to me) makes things more fragile as detritus in the
reports dir can cause load problems.  Also, as a procedural point, I
think that adding a report should be a more explicit act than just
creating a file in the directory.  Finally, there are also load-order
and redundant-loading issues that the depend mechanism avoids.  If
this change annoys people too much, we can try and hash out something
better.

That said, the depend mechanism isn't perfect, and I have this feeling
it might need some improvement.  For one thing, right now it just uses
the strings handed to the gnc:depend and gnc:support calls to know
both where to load the file and what "service" is being provided.
While this is OK, I wonder if it's sufficient for our long-term
needs...

begin 660 gnucash.diff.gz
M'XL("!#1PC@"`V=N=6-A<V@N9&EF9@"M._MSXCC2/X>_0D>V"@BQP4!XS3YF
M+I/=F_LFLZG)W-Z+JY2P!?;&MEC+#F'O[G__NB7Y`=C!V;U4*F"KU6KUNUO*
M.?GB>H+`+R4;&MLN6?&()!L11XP&).;PW:$Q(UZ,#UL>/7KANG%.X/<+)W2S
M\7<D1A1R]AQ>WW^YN2/6G%R[CA?AI-AE1/`DLAF!-\R.>;0S4\#!G'Q.0@G3
MDM@DGA;91'P=`05;+W8+"Y"5YS-"@>)PD\2`!?!\6)$=3XC#2<ACXM*G?527
M2+N<'\6$K]12`7UDZ4K4?J1K!HABE\82E4U#LF)RN8@'<L8U#S81<UDH/,!_
MQR*?O(ML%Q\^L1CY@GMWXW@S[_6VVZVY`1#3YD'O^N[=IQY-8I='HO=G[M+P
MX2?`2D/1RZ@PGLV=&=/(7/^*&U+\H$L.V/_R^>,E:3VWB'!YXCMDR<B`@(Q<
M;^VR2'&@1!*2<3R)):9$,-QYD2NODI3FL&0M)0ZS61B3/P)@R(QXMX%)+O/]
M>8E,Y4!!B(?BRX47MK3L1`+44S7S4@X&=$="QAPD$?B64!^V:H."QDIJ3*(5
MB!>8M`V!1S[?9BHV+*A8I7:5Z-47EP'?:,3D5!`EK.T(28FB19'0<YC/8DU#
M+^6;QP3PHQ%SW$U+1'9/V$$O8AL>Q?K#\#T1F_"ZU;#=@#ND/Q[W3\,JTH!D
M31&)611X(5`B"BS'`<DSM`G0&?;,["2&YY2!9H,]>S%B@Q]R`^"@(7=H]4O@
M!+YLJ*$[J4[@!"CX!A\8*]2HXZU6Q$A(*_46O6O0[37[R-<MTM*>HO"N\2%T
MV/.<F/F[AF$8Q>>S>Y#3+8T(N2+6:-X?PR\9]/O]1K?;K02\FEO6W!HHP+=O
MB6%=#DD7_DS)V[>-+KXV^D.C?T7(9[XD?XQ`18`T0KZ._.5;6YC`EV<J3.8D
MWS:ZC>[9!3F001R!M5([]GAHJ%<HBCFAC@/JNL$7TF\Z;,-"!S`$S`92/1&8
MY0A11-P`'OG.[\0$(O'X2SC(*0Q+ZM/09@9HC+$)_=])#UAP!-[4T%A_'S:<
M3=KKT)YK*PA8F!B"Q<FF,P>#>T9]]D(>P=P097,5"4!&V@Y;>2'80Y`(J?U4
M^<$E6WNAE#WH.B5?+[FS^[93L9,#PYN#.6VED9LD"YI;<,&`'>R-KP`'KJ&F
M"15,<I_M<XI>`]^!GX<-%,=@">8<DA%0+\P9H&?!MI6KA(#"!<2I'B+.PA0@
M4.NC_P8?L`MXA/3^12@[EMAIL PROTECTED]@:>KD6P+<@(2B=PF?6.B!I[\D2X@C7MP"
M]TI7&'/V"74Y?Q0YI?AH1$EH.&"L/HM$1RH`;AYV&L<^4NFP9;)>HR1L[K!#
MC.PYQD#+PP+:_%UM+0`-0(_WFY0!0[.Q#A.;"M=0N0W*F6_3@"H#)@3H*/*<
ME+DKFOC(/I_;%)V%4`&&A4]>Q,,`H^83C3P*'E;@0B3S32-"WE.96,2>S7W@
M/_EZH[]+%V4[],G3/HHTB&;6.@%][&DR39NT46F`*5(ID":D!-QYEL842"EQ
MX,>;+GCRDL'<I1\/:M]^/'!VRT/R/5N2P93T^_,!^.X])U\R8S\L7$WF@V'N
M[0>C2ZM/NO`!;\'A$QFY\P1&&VF>44&V1@IA&BQ6@`@;)-B1KT#3'EP>,/(-
M:?42$?60RX$G@-6AW7H#K#<:,OS]QA]%'5B:8#*<I%X`HW2:XH"*0C;@K3R&
M=IG_G/^^E4&OS\F[6BJ<ZNV34EBIJUUOU?[JYM-/_V[]\.GZX?;=_]W<O?MR
M_:>''S^^?WC_X7/KOQWR[T:7D*\X;.<;\B+HFT;WOR^@_'3SUWV4Z'G+46:@
M)U#^Z<?;FWV<!4F_/$%B)BBX>^`*I$(Z49:3,RUK$%MFT3E>C',>(\UKBO[:
M=OZP")MO2HRNW.D5#*\"(#>^<@!M@.6#QYG6:[EMAIL PROTECTED]>'PY(5WY
M%\V0*+\-KM_(L)!?O)7AQ2SH($<!PELIJ"P>?-=I&$K=V])!HZSD$^38I-UI
M9-:@8SR$TPBF"8FU4;`6B5;Z$ADN#H=)\Q[][1?,['S(;3'IO5>HFB\(*8MU
M)?+)QXY%DXT=2"5[?W8/8>D3?R)DC!GM")+:&;%FL]F!0`H3"K(82`E.<UD,
M+90%_+4L*8Q&QJ_R&$WP#3&AVEF+3B8[*172A.I)QLE5$MHJK($DY81F`5U(
M`_#;("5\ZD@QMB'9,Q@%FVG[4%<X%*A0"W9(6U6L^EDMW$%IOS`I589,QF7J
M<P!SK$H'8XXG-CY4F$W0B4[^F!,*WL<'SG4ZQ^N7[F$?).-/RNH"CZ05O'GS
MAMPE2]^S7]"[-!DL4;MLZ%CKTJ$#I4M?'T?BT;C,"63P196#L#V#PJM0=4TN
M!Z!S\+%G_SKE;$*-%8,C2-/Z9N<(P@MP$#Q$Q7A>$\"@@?H%G/O^P]]N;^:Z
M5M<M("S_05TQ[*O<%6N.D&\OR9:U(!6`"C]&?08O'F@T"`O!]B-4T1%`J5A,
MR9J%4,[XWJ\RG<-$$0G2V17FD>!?!*$:"20K+A$;9F/LCBYE#0YKA(A0QWG=
M0D$L%[K`P%D7$IU&XS!5T;.TOMAB'@?6!H%'+JU3?-EP`**_3W>'#9^U>ZG1
M?"`_8\*[I:%LW:'6Q2[Z-[+F\&&:I@+4X']&X#1O!%X*#\HW7#KPUFZ.)F+:
MCR#ST`_(]HN_TUAPRXK)<A'9)9%%N^JRY(4'U"9;NM-$2.>>^?TV[`]#:<,X
M:W,4/7QO*S=O@,&A+B#_'H1+(V;`J*'3E@?2+!1PS4ZGHX-)>^MB>T?%D+8-
M3@.,RT&\:BD)>):[%+78=\1>X?LS]1*W)I\4'"I:.PO_$K93&/XV(]EGX1KT
M`L;)J`!26.B;[^!;LE0/!,DSRF?+]<^R-8Y`.J29F@="M3-E/6"?-J5>4T[*
MV)0[K0(#P`%JSU=BC(=%<E/'=="$CVD)(G90A0583ZZ\M<BBON1?2J"A@`P%
M9$"2H+ILL'"U3\S]08E7+`P>^\5\\,`SY@-U$Z2*&=9\.`6'FGO'T51Z1_R8
MZ8B<YS"8H1PD+*3Y\%EU$B#&(GOAQ3V3?DLT.RK*%*?+\!LI)!"PC/Q=1SO+
MDFP,@=)1%\NM-/1*?<C"+Z+13B?5E)<2MRQ;`^M5Z4)[17W!4*SLV6;RY5Y;
M!PE.8?4ZATJ)"VJ0`V75.].#1@2A'G0I,N)":F?H+#%%44"?,E$FB,8+R6.V
M:KM=8'@+.8I?.T3^+8`=V-Q[G5B@330E,'QH]6D6YVEI9^)O[H]JH2B33),Z
MI*+8(T.*R9[<N@6YR-'S59[0E(JSR.'_N3SWX+=>Z$!9>L@QQ8&YYE;G2.Y'
MJ5S&&XT]2=NUBA69\$]B*JA)IB?'YB,+&35^(2.2WHX7KOC#Q6&Z6-3@HTST
M-ZJPQI.)4;#X#TJ3N^1$+;1/PLLZW2V+#G45^V!RF79W*\1XQ*?3>EB>Y%?H
M786>=E^<5%-93]'Q2HVMA6Y/;;OD9;V5$%E<+PL,Z?A>:""EKJ9<_P_+3O4]
MW>$3%$.X6&&GADJX(:,">4#4EAR.W21\[.BT0B>[4ME2!-BX7H<<4E/=JM99
M:1(G$3KVEN\35)Q$G,PFRLXO*K.+4N"J;*,,N#3[*`-\739R$H,U'^S7;I-+
M:TBZ\/=*YB;`9UT%V-2W$U\WLS$#IC8:F@`98-]T`Z^]I>=[\4X=[,A\6"&`
M1R]4+Z"N$(+AX:J=1!%65GC?`.9#THY%52)4.89]4;Z*MY#7FPU9F@"B3SQF
MNMI2IYZ.;%Z*0CM"Z96#@F^6G]4U)4VW-(Z1"9!%D:\#>#`#^?#68XR9/%IC
M;[VKSEOT<56SFJ7HN$#!@18CX$Z")]!MSV;&#':V9L^H_U!G_)(`"TA+VI!T
MY,HLBKDT:&)BHZZF6,LR[8I]Z18"N<6.\0Y/Y_%4/#<[H$S>W^`;,%S\XC`_
MIJ?3ZK)CP6I#*`.N-(02X')#*`%\I2&<P@"&`!A&Q:/C*SPZGJ1F8%P8PH9*
ME\&72MTH647KQHD&2"-K:YX41W;.6RV$'*22]1E(.<.SX;J=H:-Y!\R=S/N3
M(G-'R-RQJG_*>9FA4AR4?0QLFF`/'33:$R[8N3R;C.+,:>Q8C)T$M(3C.'.:
MMP>G\=4</@2LY/,!8#FW#X!>J=HOS9:<'Q7.R$;`].[H<IJJ]0<(DKZ?`#NR
M:R-+*CR;Q,QV0^^7!%Z"7RO<<I'3\!PF/=]&=_]#F%SCP6.E-`^(S&1ZISMP
M.YY$!3\.;IFF)M$A2Y_;C\3U'$5A(&=F)YD0/63LD$>@YK$E]1SVU`L3"/U5
MTCRZ65,ES0/`<FD>`)W]%;CWGMED:!%K.@<CZO>)-1O/RJ5Y./M`FL,]:?8O
M^VA'LH_016DBW>H&4]HB5%<2-*-\1I^P?:=%)T_S2L5UW,WIE@>CBFA8!EKA
M',M`]VR_#*!$G5X5*D]Z@O*9U0ZA`KY2D\KARQ6J'/:57J(&$E"OZ7S0+YP=
MH;,8YLY"53;8ZT6M*F!4!AMB3LB34*5]G_D2/#.Y9=$C\R'_64-!^?@V\")J
MABSN5'J*2IEUBUF4D*T,]/,N!=]`?5S+P`)`Q@$\I@$G93,A:+3[;O]J6WZ-
MK7"Y[1T>X%3=<#LG[_%=6F;HGSFQS+X:8_J``&^9Z+']BVF070QTX#PG/V2P
MRUV.++L#2@:F!/O,($D6;.^*PIS\G0D8NWFV_02OTJ@+CQI%>_'N/^9%KW/]
MTWV[9U[\9_&/#L!65)P:]O/U:=C+I\4_3B*ZO[ZNO^H_Q>9?"]/LGL#;Z_#E
MSR=AU@MC&]'-PL!+3*":)R?<`JN1<?4!3<@XXI/@JFN],&THCUEM:)^O:\/"
M_N)$U`9W3T*:%PN\;[PPU[_6@JU#+,(MO;`6G-3X6I#HLVL#GF;1,SBK6N@`
M$#15?SDU@461`-A38`MS<5X#[,N['^Y/XT),YR?!?&\9<^[74ITZB@.:&(#)
MN35U$8K:&ER!^"UJ@,%>1"W9>:=]A[I?!HH8U(8U6+B&`+,P\&K_U8/T/:9=
MWTW)3+6.P-8(KZ!-G]:@SUX8>!\4@E$M$4;VHI=2A??:ZNRB9-)O6LF-`[_F
M/,F`7B:IFLM!UK#H+3F/L;@!`>%SO8E;<)T]*=O"JDKF6M@.KR]N$[N@=:1=
MX%`Q[KQR:J3:%/D;(Q+U]OU+PJ$&5.(Q-I$'V=/I3<:/4(A#U7U1RQXE074`
M(=NI%V<B]G.]W>F:!P1+8_=U\3'@]2+%.N`U\9T$V_!7*L'=CU^^__#QYG2X
ML&D,B9*S,.*E7\MK90Z2Q[7(W@B6.'QAJ/\?JN525"A)*:NS"'L&H[8!/J!V
MQ,5"_I?5R9E>*+/F12_`PF#-Q(-G36NYRGT;H[:\3@V2'+URIHRN$#1?;]=9
MO'W]5-"YURE3T>T6.?1$6H"Y][<E9<;(')L#`PHM*F2M*1,YGSTQWW1;Q!I.
MK\AT.IM8T]EH0(9#:SH"!!O2*OQOT'0RM29D=C48S/KCR8#TK3[^YY."*[N"
M/IC,KB3\=#:%:A?A)Q,-7W5[=CB[FJDYX[%E[:]1<IES,!R/)?AD-NY/%?CH
M`#R_@S>$<04]GEQ5("^V#T;#R4C!3V;]%^'+SY^L\<P::`3#EQ<L[]N/K7%*
MP*`_>G%^H=$\&D_ZZ:S!Y,591RU4:]"_&J:3Q\/"9/ODO[B1=-7^8/CBJE7M
M&FLV&LU2?O7[.8Y"/^"P\B\T!?8Z!H]>3/ZI>J!.=7G_+]TQP.G7+K,?11+,
700E'`&9-A\2R^M.^@OE_[BU\*',[````
`
end

-- 
Rob Browning <[EMAIL PROTECTED]> PGP=E80E0D04F521A094 532B97F5D64E3930
I may have lost some mail recently, please remind me if I overlook something.

--
Gnucash Developer's List 
To unsubscribe send empty email to: [EMAIL PROTECTED]

Reply via email to