Hey Giovanni, On Thu, 2012-10-18 at 21:22 +0200, Giovanni Campagna wrote: > Hello Shell and Control Center developers > > I've stumbled upon https://bugzilla.gnome.org/show_bug.cgi?id=675902, > which is a bug about the volume menu in gnome-shell, and I had to > update some of the copy-pasted bits from libgnome-volume-control. > What I found out is that the trees in gnome-shell and > gnome-control-center had diverged, with one missing features and the > other having bugs with introspection.
Your upstream for that code was gnome-control-center. If it diverged, it's because you (or others) fixed the code in gnome-shell like they owned it and never pushed the patches to gnome-control-center. > This situation is bad, in my > opinion, as it leads to work and code duplication. > Therefore I propose to merge libgnome-volume-control (at least the > shared GvcMixerControl and related parts) into libgnome-desktop, so > that it can be accessed by all interested core modules. Alternatively, > we could setup a libgnome-volume-control git module, and use git > submodules to access it, like we do for libgd and libgsystem. The problem with a git submodule is that I'll get told off when I do changes to gnome-control-center's sound panel, because I break API and it breaks gnome-shell or gnome-settings-daemon. It's not that the API isn't stable, it's that I don't want to have to think about it being stable. Adding it to gnome-desktop is absolutely out of the question. > What do you think? > If there are no objections, I'll prepare a patch for libgnome-desktop. > I will probably rename Gvc to Gnome, as required by introspection, and > thus prepare an update for the affected modules. I sense much anger and pain in making it a sub-module, but if you're willing to do the work on unbreaking gnome-shell every time I break it for gnome-control-center, then you're more than welcome. I'll be waiting for the introspection fixes, and the patches to gnome-settings-daemon to sync the code. Cheers _______________________________________________ gnome-shell-list mailing list gnome-shell-list@gnome.org https://mail.gnome.org/mailman/listinfo/gnome-shell-list
