Le 07/09/2016 à 11:39, Johan Cwiklinski a écrit : >> * All Pull Requests must be reviewed by another developer, this review >> is needed and check these points: >> * Check the code, if it's coherent with the issue, coding standards >> * check if there are enough tests (unit, integration). So a Pull >> Request NEED HAVE tests, if no test, refure merge and add comment >> in it >> * verify travis (run tests in travis-ci.org) pass > > Agree, but disagree (on the tests part) :p > > We should probably have tests on new features, but when it is actually > possible; if we need to refactor some other (big) parts of code to get tests > running, this is probably not a good idea ; and for bugfixes, we probably > cannot ask the developper to spend all the required time to write all tests > on some cases. > > At the end, this rule will really become a MUST, but I'm not sure it is > possible right now (talking about exeprience on some other projets where some > parts of the code cannot be unit tested by design - or mistakes). I can be > wrong, I'm quite new to the project ;) > > On the basics, I totally agree, but maybe should we consider merging without > tests would be possible with a (really!) good reason for now? > Of course, existing unit tests MUST be OK, in any case.
+1 with Johan We don't have enough test but we also don't have enough "testable" part (e.g.: WebUI, LDAP...) Remi _______________________________________________ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev
