On Tuesday, August 25, 2015 at 10:29:55 PM UTC+3, Achilleas Pipis wrote: > > On 08/25/2015 10:06 PM, Victor Porton wrote: > > I am going to learn Ruby and add #COMMIT or maybe %COMMIT (autoreplaced > > with current commit which the user is viewing) to your markup language. > > > > Will you accept my patch? > > > > Better open an issue in https://gitlab.com/gitlab-org/gitlab-ce/issues > and explain in detail what you want to do. Then link it back in this > thread. > "The GitLab CE issue tracker on GitLab.com <https://gitlab.com/gitlab-org/gitlab-ce/issues> is only for obvious errors in the latest stable or development release of GitLab <https://gitlab.com/gitlab-org/gitlab-ce/blob/master/MAINTENANCE.md>. If something is wrong but it is not a regression compared to older versions of GitLab please do not open an issue but a feature request."
So your advice is against the official GitLab practice. > > I want to ensure that my patch will be accepted for the production > > GitLab.com server as otherwise I don't want to spend my time learning > > Ruby and writing this code. > > > > Make sure you read > https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md and > in particular > > https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#contribution-acceptance-criteria > > > So if your patch is well tested and provides functionality that is > useful, I don't see why not to get accepted. > > > -- > Blog: http://axilleas.me > -- You received this message because you are subscribed to the Google Groups "GitLab" group. To unsubscribe from this group and stop receiving emails from it, send an email to gitlabhq+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/gitlabhq/c9d7c13b-a126-4b16-94d3-8f18d48acb58%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
