On 08/25/2015 10:06 PM, Victor Porton wrote:
> I am going to learn Ruby and add #COMMIT or maybe %COMMIT (autoreplaced
> with current commit which the user is viewing) to your markup language.
> 
> Will you accept my patch?
> 

Better open an issue in https://gitlab.com/gitlab-org/gitlab-ce/issues
and explain in detail what you want to do. Then link it back in this thread.

> I want to ensure that my patch will be accepted for the production
> GitLab.com server as otherwise I don't want to spend my time learning
> Ruby and writing this code.
> 

Make sure you read
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md and
in particular
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#contribution-acceptance-criteria

So if your patch is well tested and provides functionality that is
useful, I don't see why not to get accepted.


-- 
Blog: http://axilleas.me

-- 
You received this message because you are subscribed to the Google Groups 
"GitLab" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to gitlabhq+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/gitlabhq/55DCC22B.3070709%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to