LLDay commented on code in PR #20009:
URL: https://github.com/apache/datafusion/pull/20009#discussion_r2738589626
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -647,6 +650,97 @@ impl ExecutionPlan for SymmetricHashJoinExec {
)
.map(|e| Some(Arc::new(e) as _))
}
+
+ fn physical_expressions<'a>(
+ &'a self,
+ ) -> Option<Box<dyn Iterator<Item = Arc<dyn PhysicalExpr>> + 'a>> {
+ let left_sort_iter = self
Review Comment:
As far as I understand, `on`
[stores](https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/joins/utils.rs#L87)
`Column` expressions. I've
[tested](https://github.com/LLDay/datafusion/blob/1c0d307aacc91cbd2af8e1c87b9361fe7c4b00d3/datafusion/core/tests/physical_optimizer/physical_expr_resolver.rs#L321)
current implementation with the old `ResolvePlaceholdersExec` and it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
