novartole commented on code in PR #2184:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2184#discussion_r2733800871
##########
src/tokenizer.rs:
##########
@@ -917,6 +937,23 @@ impl<'a> Tokenizer<'a> {
self
}
+ /// Return an iterator over tokens
+ pub fn iter(&mut self) -> TokenWithLocationIter<'a, '_> {
Review Comment:
1. `iter` doesn't reflect what the method does and sounds too general.
2. `TokenWithLocationIter` returns `TokenWithSpan` rather instead something
with `Location`.
How about giving it a more specific name?
```suggestion
fn token_with_span_iter(&mut self) -> TokenWithSpanIter<'a, '_> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
