coderfender commented on PR #3248:
URL:
https://github.com/apache/datafusion-comet/pull/3248#issuecomment-3802441709
Thank you for the suggestion Andy . These are the benchmarks before and
after removing string allocations even for happy paths
```
Before :
cast_string_to_decimal/legacy/decimal_38_10
time: [78.329 µs 78.724 µs 79.231 µs]
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
cast_string_to_decimal/ansi/decimal_38_10
time: [79.564 µs 80.966 µs 82.546 µs]
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) high mild
5 (5.00%) high severe
After :
cast_string_to_decimal/legacy/decimal_38_10
time: [38.066 µs 38.202 µs 38.453 µs]
change: [−51.446% −51.044% −50.400%] (p = 0.00 <
0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
6 (6.00%) high mild
6 (6.00%) high severe
cast_string_to_decimal/ansi/decimal_38_10
time: [38.534 µs 38.629 µs 38.726 µs]
change: [−52.226% −51.738% −51.309%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
cast_string_to_decimal/try/decimal_38_10
time: [39.055 µs 39.377 µs 39.803 µs]
change: [−50.359% −49.526% −48.560%] (p = 0.00 <
0.05)
Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) high mild
11 (11.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
