alamb commented on code in PR #19958: URL: https://github.com/apache/datafusion/pull/19958#discussion_r2722337083
########## docs/source/contributor-guide/testing.md: ########## @@ -104,6 +104,7 @@ locally by following the [instructions in the documentation]. [sqlite test suite]: https://www.sqlite.org/sqllogictest/dir?ci=tip [instructions in the documentation]: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest#running-tests-sqlite +[extended.yml]: https://github.com/apache/datafusion/blob/main/.github/workflows/extended.yml Review Comment: Most of the other changes are related to things that have links but no definition of the link ########## datafusion/functions/src/datetime/to_timestamp.rs: ########## @@ -42,7 +42,8 @@ use datafusion_macros::user_doc; description = r#" Converts a value to a timestamp (`YYYY-MM-DDT00:00:00.000000<TZ>`) in the session time zone. Supports strings, integer, unsigned integer, and double types as input. Strings are parsed as RFC3339 (e.g. '2023-07-20T05:44:00') -if no [Chrono formats] are provided. Strings that parse without a time zone are treated as if they are in the +if no [Chrono formats](https://docs.rs/chrono/latest/chrono/format/strftime/index.html) are provided. Review Comment: there was no definition of chrono formats, so I added one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
