avantgardnerio commented on code in PR #19653:
URL: https://github.com/apache/datafusion/pull/19653#discussion_r2700506249
##########
datafusion/core/benches/data_utils/mod.rs:
##########
@@ -276,3 +276,43 @@ fn test_schema(use_view: bool) -> SchemaRef {
]))
}
}
+
+/// Create deterministic data for DISTINCT benchmarks with predictable
trace_ids
+/// This ensures consistent results across benchmark runs
+#[allow(dead_code)]
Review Comment:
I think it is code that is only used for benchmarks that I wasn't sure how
else to allow. Perhaps it needs to be moved into the benchmark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
