alamb commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-3749255055
My personal suggestion here is to try and find some way to incrementally move this forward (as we were discussing elsewhere). Our ability to replace the entire group by hash machinery in one go will be very hard, both to review, as well as to track down potential regressions So I personally recommend focusing on some core usecases first (e.g. single column hash aggregates for Primtive and String/StringViews) and see what you can get working. We can then slowly add more functionality (multi column grouping, more types, spilling, etc) incrementally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
