sebbegg commented on PR #1351: URL: https://github.com/apache/datafusion-ballista/pull/1351#issuecomment-3725540036
@milenkovicm Feel free to have another look - made some updates: * The `GetJobStatusResult` now has the `flight_endpoint` - so there's no extra request involved to fetch this information. * As @martin-g suggested the proxy now checks that the requested `host:port` belongs to an active executor * Used `tokio::select!` to exit in case the flight proxy panics Unfortunately this is still missing tests. A proper test would probably be some sort of integration test with scheduler and at least one executor. I looked through the test-utils, but I'm not sure there's something that could be used for that... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
