comphead commented on code in PR #3052:
URL: https://github.com/apache/datafusion-comet/pull/3052#discussion_r2669131269
##########
native/spark-expr/src/math_funcs/round.rs:
##########
@@ -150,9 +161,19 @@ pub fn spark_round(
let (precision, scale) = get_precision_scale(data_type);
make_decimal_scalar(a, precision, scale, &f)
}
- ScalarValue::Float32(_) | ScalarValue::Float64(_) =>
Ok(ColumnarValue::Scalar(
- ScalarValue::try_from_array(&round(&[a.to_array()?,
args[1].to_array(1)?])?, 0)?,
Review Comment:
the direct function is private now, creating UDF instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
