alamb commented on code in PR #19584: URL: https://github.com/apache/datafusion/pull/19584#discussion_r2656415606
########## datafusion/sqllogictest/test_files/decimal.slt: ########## @@ -1217,3 +1217,18 @@ NULL query error Arrow error: Invalid argument error: 1.10 is too large to store in a Decimal128 of precision 2. Max is 0.99 select cast(1.1 as decimal(2, 2)) + 1; + +query I +SELECT CAST(123.45 AS INT); Review Comment: these tests pass on main as well (so I don't think they cover the intended usecase) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
