2010YOUY01 commented on code in PR #19560:
URL: https://github.com/apache/datafusion/pull/19560#discussion_r2655221598
##########
ci/scripts/rust_fmt.sh:
##########
@@ -17,5 +17,52 @@
# specific language governing permissions and limitations
# under the License.
-set -ex
-cargo fmt --all -- --check
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SCRIPT_NAME="$(basename "${BASH_SOURCE[0]}")"
+source "${SCRIPT_DIR}/utils/git.sh"
+
+MODE="check"
+ALLOW_DIRTY=0
+
+usage() {
+ cat >&2 <<EOF
+Usage: $0 [--write] [--allow-dirty]
+
+Runs \`cargo fmt --all -- --check\` by default to verify Rust formatting.
+--write Run \`cargo fmt --all\` to auto-fix formatting (requires a
clean git worktree, no uncommitted changes).
+--allow-dirty Allow \`--write\` to run even when the git worktree has
uncommitted changes.
+EOF
+ exit 1
+}
+
+while [[ $# -gt 0 ]]; do
+ case "$1" in
+ --write)
+ MODE="write"
+ ;;
+ --allow-dirty)
+ ALLOW_DIRTY=1
+ ;;
+ -h|--help)
+ usage
+ ;;
+ *)
+ usage
+ ;;
+ esac
+ shift
+done
+
+if [[ "$MODE" == "write" && $ALLOW_DIRTY -eq 0 ]]; then
+ require_clean_work_tree "$SCRIPT_NAME" || exit 1
+fi
+
+if [[ "$MODE" == "write" ]]; then
+ echo "[${SCRIPT_NAME}] \`cargo fmt --all\`"
+ cargo fmt --all
+else
+ echo "[${SCRIPT_NAME}] \`cargo fmt --all -- --check\`"
+ cargo fmt --all -- --check
+fi
Review Comment:
Good point, updated.
Perhaps we should introduce some lint tools to check the existing bash
scripts, to prevent similar issues in the future 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
