alamb commented on PR #19520: URL: https://github.com/apache/datafusion/pull/19520#issuecomment-3699128520
> Not sure how much the existing benchmarks will show improvement as they are not testing a lot of unique values Several of the click bench queries, such as q21 have many unique group values For example, q17 / 18 / 19 all have 21M groups: https://github.com/apache/datafusion/blob/92d8632b01b9897a5fd1f9fdb753156b847e8ba9/benchmarks/queries/clickbench/queries/q17.sql#L4 You can see the analysis I did of the distribution here: <img width="1918" height="878" alt="Screenshot 2025-12-30 at 6 54 12 AM" src="https://github.com/user-attachments/assets/794beaed-5baa-453f-a2ca-bdd8565a4493"; /> https://docs.google.com/spreadsheets/d/1NZuh_dEs9gX5uEp8AQ3DfvkNfC6bXFayQtFkjeKjNxQ/edit?gid=0#gid=0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
