mag1c1an1 commented on PR #19397: URL: https://github.com/apache/datafusion/pull/19397#issuecomment-3695744902
Hi @alamb . I'm very sorry that I only saw your comment now. I upgraded to version 51 instead of the main branch. What puzzles me is the following description in the [upgrading guide](https://datafusion.apache.org/library-user-guide/upgrading.html#refactoring-of-filesource-constructors-and-filescanconfigbuilder-to-accept-schemas-upfront): 1. "FileSource constructors now require TableSchema: All built-in file sources now take the schema in their constructor:" ``` - let source = ParquetSource::default(); + let source = ParquetSource::new(table_schema); ``` > But in [api doc](https://docs.rs/datafusion/51.0.0/datafusion/datasource/physical_plan/struct.ParquetSource.html#method.new) , the new function of `ParquetSource` take `TableParquetOptions`. 2. "FileScanConfigBuilder no longer takes schema as a parameter: The schema is now passed via the FileSource:" ``` - FileScanConfigBuilder::new(url, schema, source) + FileScanConfigBuilder::new(url, source) ``` > But in [api doc](https://docs.rs/datafusion/51.0.0/datafusion/datasource/physical_plan/struct.FileScanConfigBuilder.html#method.new) , the new function of `FileScanConfigBuilder` still needs a file schema. In my understanding, the meaning of the above code block is that the API of 51 has changed now. Please make the necessary modifications, such as removing the code starting with '- ' and replacing it with the code starting with '+ '. Am I mistaken in my interpretation? All the code blocks come from the "DataFusion 51" section of the upgrading guide. I hope my poor expression skills can correctly convey my intention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
