JSOD11 commented on issue #19164: URL: https://github.com/apache/datafusion/issues/19164#issuecomment-3690752322
After taking a look I think this one could be in the same boat as https://github.com/apache/datafusion/issues/19165. Taking a look at the Spark docs, I see the factorial function defined [here](https://github.com/apache/spark/blob/316322cbcb55ff5c1b4e479bc2aae12babdae534/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L639) with `nullIntolerant` and `nullable` both set to `true`. Is it correct that `factorial` does not need changes then, or is something different here? cc @Jefffrey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
