comphead commented on code in PR #2943:
URL: https://github.com/apache/datafusion-comet/pull/2943#discussion_r2641894084
##########
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##########
@@ -79,4 +79,14 @@ object DataTypeSupport {
case _: StructType | _: ArrayType | _: MapType => true
case _ => false
}
+
+ def hasTemporalType(t: DataType): Boolean = t match {
+ case DataTypes.DateType | DataTypes.TimestampType |
DataTypes.TimestampNTZType =>
Review Comment:
wondering if interval can also be considered as temporal? Probably not, it
is more like duration rather than representing any point of time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
