UBarney commented on code in PR #19411:
URL: https://github.com/apache/datafusion/pull/19411#discussion_r2637856134
##########
benchmarks/compare.py:
##########
@@ -154,17 +154,17 @@ def compare(
baseline = BenchmarkRun.load_from_file(baseline_path)
comparison = BenchmarkRun.load_from_file(comparison_path)
- console = Console()
+ console = Console(width=200)
Review Comment:
I've increased the console width to 200. I added more information like
'density' to the queryName, which made it longer and caused it to be cut off in
the output before
##########
benchmarks/compare.py:
##########
@@ -154,17 +154,17 @@ def compare(
baseline = BenchmarkRun.load_from_file(baseline_path)
comparison = BenchmarkRun.load_from_file(comparison_path)
- console = Console()
+ console = Console(width=200)
# use basename as the column names
- baseline_header = baseline_path.parent.stem
- comparison_header = comparison_path.parent.stem
+ baseline_header = baseline_path.parent.name
+ comparison_header = comparison_path.parent.name
Review Comment:
Before, a path like `.../density=0.1/...` was incorrectly shortened to
`density=0`. Now, by using `.parent.name`, we correctly get the full directory
name, `density=0.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
