feniljain commented on code in PR #19342: URL: https://github.com/apache/datafusion/pull/19342#discussion_r2637134301
########## datafusion/physical-plan/src/async_func.rs: ########## Review Comment: @alamb I was playing around with this and have a small doubt: Lets consider the case where input batches are smaller than coalescer's target batch size. Above code is implemented as a `then` on `input_stream`. Every iteration we need to return at least one batch. That would mean we will have to poll `input_stream` again in `then` itself. But as `input_stream` is already used we can not use it again in `then` block, this is causing an error and I don't see a good way out of it except wrapping it around a stream. Should we leave it as it is? Do help me if I am missing some other obvious thing here 🙈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
