timsaucer commented on code in PR #19281:
URL: https://github.com/apache/datafusion/pull/19281#discussion_r2636346367
##########
datafusion/ffi/tests/ffi_udaf.rs:
##########
@@ -126,4 +128,69 @@ mod tests {
Ok(())
}
+
+ /// This test FFI UDFs can be used as inputs to FFI Aggregate UDFs.
+ /// Really this is a test of the Protobuf serialization and deserialization
+ /// using the TaskContextProvider. It can be demonstrated through the
Review Comment:
This is. It's passing the logical expression for the scalar UDF as input to
the accumulator arguments. Then on the physical side it is using the FFI
Physical expressions. Since it's more of an end-to-end test you get both sides
of the processing handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
