timsaucer commented on code in PR #19281:
URL: https://github.com/apache/datafusion/pull/19281#discussion_r2635795235
##########
datafusion/ffi/src/table_provider.rs:
##########
@@ -267,53 +266,40 @@ unsafe extern "C" fn scan_fn_wrapper(
let plan = rresult_return!(
internal_provider
- .scan(&ctx.state(), Some(&projections), &filters, limit.into())
+ .scan(session, Some(&projections), &filters, limit.into())
.await
);
- RResult::ROk(FFI_ExecutionPlan::new(
- plan,
- ctx.task_ctx(),
- runtime.clone(),
- ))
+ RResult::ROk(FFI_ExecutionPlan::new(plan, runtime.clone()))
}
.into_ffi()
}
unsafe extern "C" fn insert_into_fn_wrapper(
provider: &FFI_TableProvider,
- session_config: &FFI_SessionConfig,
+ session: FFI_SessionRef,
input: &FFI_ExecutionPlan,
insert_op: FFI_InsertOp,
) -> FfiFuture<FFIResult<FFI_ExecutionPlan>> {
let runtime = provider.runtime().clone();
let internal_provider = Arc::clone(provider.inner());
- let session_config = session_config.clone();
let input = input.clone();
async move {
- let config = rresult_return!(SessionConfig::try_from(&session_config));
- let session = SessionStateBuilder::new()
- .with_default_features()
- .with_config(config)
- .build();
- let ctx = SessionContext::new_with_state(session);
+ let foreign_session =
rresult_return!(ForeignSession::try_from(&session));
Review Comment:
The issue with this is around borrowed/owned session. We need to pass
borrowed Session into the methods below. Instead I used an `mut Option<>` and
took the ref from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
