geoffreyclaude commented on PR #18832: URL: https://github.com/apache/datafusion/pull/18832#issuecomment-3643581726
> The benchmarks are now looking *very* good, and this has gone through several rounds of review, all of it addressed. But there are significant changes since the last approvals. @geoffreyclaude could you give another review and approve if you think it's ready so we can merge this piece and continue work in https://github.com/apache/datafusion/issues/19241 The tests you added as a dedicated PR give a lot of confidence this isn't introducing any functional regression. And perf-wise, then benchmarks speak for themselves! Do we have more generic benches that exercise this path? Maybe the Clickbench ones? Would be nice to see the big picture and make sure this isn't "benchmaxing" with unexpected adverse effects in real life. Otherwise, ✅ from me of course. You addressed my remaining two nits already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
