ethan-tyler commented on code in PR #17702:
URL: https://github.com/apache/datafusion/pull/17702#discussion_r2608277295
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -625,7 +625,7 @@ impl AsLogicalPlan for LogicalPlanNode {
create_extern_table.name.as_ref(),
"CreateExternalTable",
)?,
- location: create_extern_table.location.clone(),
+ locations: vec![create_extern_table.location.clone()],
Review Comment:
Yeah this is the main issue. Either split here or change proto to `repeated
string locations`. Going with the schema change is cleaner than encoding lists
in strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
