ethan-tyler commented on code in PR #17702:
URL: https://github.com/apache/datafusion/pull/17702#discussion_r2608236871
##########
datafusion/catalog/src/stream.rs:
##########
@@ -53,8 +53,12 @@ impl TableProviderFactory for StreamTableFactory {
state: &dyn Session,
cmd: &CreateExternalTable,
) -> Result<Arc<dyn TableProvider>> {
+ let location = match cmd.locations.len() {
Review Comment:
I think the runtime check is fine here. Streams don't support multiple
locations, so failing clearly makes sense. You could take &str directly but
then callers have to decide which location to pass.
Maybe tweak the error message to suggest using a listing table instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
